xargs: Implement replace / -I (Closes: #310)#323
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #323 +/- ##
==========================================
+ Coverage 58.12% 58.36% +0.23%
==========================================
Files 30 30
Lines 3630 3713 +83
Branches 821 841 +20
==========================================
+ Hits 2110 2167 +57
- Misses 1220 1223 +3
- Partials 300 323 +23 ☔ View full report in Codecov by Sentry. |
sylvestre
force-pushed
the
replace
branch
2 times, most recently
from
ed2cbe6 to
3319bda
Compare
cakebaker
reviewed
Feb 26, 2024
cakebaker
reviewed
Feb 27, 2024
sylvestre
force-pushed
the
replace
branch
2 times, most recently
from
5895040 to
0363266
Compare
sylvestre
changed the title
cakebaker
reviewed
Mar 25, 2024
cakebaker
reviewed
Mar 26, 2024
cakebaker
reviewed
Mar 27, 2024
cakebaker
reviewed
Mar 27, 2024
cakebaker
reviewed
Mar 27, 2024
cakebaker
reviewed
Mar 29, 2024
cakebaker
reviewed
Apr 2, 2024
cakebaker
reviewed
Apr 2, 2024
cakebaker
reviewed
Apr 2, 2024
cakebaker
reviewed
Apr 2, 2024
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
Co-authored-by: Daniel Hofstetter <daniel.hofstetter@42dh.com>
sylvestre
commented
Apr 2, 2024
sylvestre
left a comment
sylvestre
left a comment
Contributor
Author
There was a problem hiding this comment.
i think we are good this time :)
Contributor
|
Good work :) |
Contributor
Author
|
many thanks for this terrific review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #310