Skip to content

clippy: Fix clippy warning.#357

Merged
cakebaker merged 1 commit into
uutils:mainfrom
hanbings:clippy
Apr 23, 2024
Merged

clippy: Fix clippy warning.#357
cakebaker merged 1 commit into
uutils:mainfrom
hanbings:clippy

Conversation

@hanbings

Copy link
Copy Markdown
Collaborator

I'm sorry that I wrote some redundant code at #353 and #342 which caused cargo clippy --all-targets --all-features to generate multiple warnings.

Fix them in this PR.

@codecov

codecov Bot commented Apr 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.58%. Comparing base (6a83795) to head (acd5c4b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   59.35%   58.58%   -0.78%     
==========================================
  Files          30       30              
  Lines        3831     3815      -16     
  Branches      872      859      -13     
==========================================
- Hits         2274     2235      -39     
- Misses       1218     1257      +39     
+ Partials      339      323      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cakebaker cakebaker merged commit bb667e3 into uutils:main Apr 23, 2024
@cakebaker

Copy link
Copy Markdown
Contributor

No need to be sorry :) I added --all-targets to the CI in #359, so in the future the CI should catch such issues.

Thanks for fixing the issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants