find: Fix convert_arg_to_comparable_value() function parsing unexpected characters.#361
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #361 +/- ##
==========================================
+ Coverage 58.34% 58.88% +0.53%
==========================================
Files 30 30
Lines 3815 3831 +16
Branches 860 860
==========================================
+ Hits 2226 2256 +30
+ Misses 1257 1254 -3
+ Partials 332 321 -11 ☔ View full report in Codecov by Sentry. |
Contributor
|
please add integration tests too to trigger the error and make sure we are handling it correctly |
Collaborator
Author
|
Thanks. But it may be that Codecov does not detect the diff because the PR only fixes regular expressions, so the coverage changes cannot be seen in the Codecov report. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
convert_arg_to_comparable_value() as mentioned in #355 (comment) parses some strange characters.
The original regular expression was
([+-]?)(\d+)$, which did a partial match and only included1%2of2as part of the match.After adding the
^limiter (^([+-]?)(\d+)$), the expression can be restricted to only match+-or0-9.