find: make InodeMatcher & LinksMatcher unix-only#393
Merged
sylvestre merged 1 commit intoJun 24, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 60.48% 60.51% +0.02%
==========================================
Files 32 32
Lines 4069 4067 -2
Branches 895 893 -2
==========================================
Hits 2461 2461
Misses 1254 1254
+ Partials 354 352 -2 ☔ View full report in Codecov by Sentry. |
cakebaker
force-pushed
the
find_make_inode_matcher_and_links_matcher_unix_only
branch
from
5e02694 to
0456e3a
Compare
sylvestre
force-pushed
the
find_make_inode_matcher_and_links_matcher_unix_only
branch
from
0456e3a to
a240606
Compare
sylvestre
force-pushed
the
find_make_inode_matcher_and_links_matcher_unix_only
branch
from
a240606 to
ee2159f
Compare
sylvestre
force-pushed
the
find_make_inode_matcher_and_links_matcher_unix_only
branch
from
ee2159f to
cd0e119
Compare
|
GNU testsuite comparison: |
Contributor
|
@hanbings maybe we should display it only when here are changes. |
Collaborator
OK, I'll open a new PR to work on it. |
cakebaker
deleted the
find_make_inode_matcher_and_links_matcher_unix_only
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a refactoring that makes the implementations of
InodeMatcherandLinksMatcherunix-only. And moves the error handling for other platforms to where we handle-inumand-links.The refactoring is done to get rid of two "field x is never read" warnings on Windows (see, for example, https://github.com/uutils/findutils/actions/runs/9271426702/job/25506758917#step:6:185)