find: Fix -newerXY test code for Windows platform.#394
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 58.80% 58.88% +0.07%
==========================================
Files 30 30
Lines 3855 3855
Branches 851 849 -2
==========================================
+ Hits 2267 2270 +3
Misses 1254 1254
+ Partials 334 331 -3 ☔ View full report in Codecov by Sentry. |
Contributor
|
please add tests to make sure we don't regress, thanks |
Contributor
|
@sylvestre: hm, what tests are you looking for? As far as I see it, this PR is about fixing the broken tests on Windows, so the tests are already there. |
Contributor
|
oups, sorry |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs::remove_filein Windows platform tests may return anOk()even if the file is not deleted immediately, which will cause an error in the code in the test that assumes the file is deleted./separators were accidentally escaped as\\. Now it has been changed to usecontainsto determine whether the output contains a specific path and ignore the path separator problem.