Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.48%. Comparing base (84e4be8) to head (1cd319d).

@@           Coverage Diff           @@
##             main     #400   +/-   ##
=======================================
  Coverage   60.48%   60.48%           
=======================================
  Files          32       32           
  Lines        4069     4069           
  Branches      895      895           
=======================================
  Hits         2461     2461           
  Misses       1254     1254           
  Partials      354      354           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nice !
could you please fix the conflict? thanks

Testing is hard, don't hesitate if you need to land it to test it further

Testing is hard, don't hesitate if you need to land it to test it further

It seems that the compatibility information in Annotations is extracted correctly, but Actions gets a 403 unauthorized error when posting a comment. I guess the Token is not valid. Do we have a Secret named GITHUB_TOKEN or another Secret with comment permissions set in the repo?

and... I'm sorry for spending so much time testing.

@tertsdiepraam do you remember if it can be tested inside a PR or it needs to be merged first ?

I think it had to be merged...

Also, I split it into 2 workflows on purpose, so that the workflow that posts the comments could have more permissions but the other workflow could be run from the PR. We should probably do the same here. See also some of the discussions and stuff around this feature in coreutils: uutils/coreutils#4010

I'm separating the code for sending PR comments into a new CI file, but Github Actions only runs the CI file that exists in the default branch. I'm not sure the code will work, can we merge this PR first and then fix the code issues?

sure, i guess it isn't a draft anymore then ?

done

it is marked as skipped ?!

https://github.com/uutils/findutils/actions/workflows/comment.yml

yeah, I feel weird about that. I'll fix it in my fork. Thanks.

yeah, I feel weird about that. I'll fix it in my fork. Thanks.

don't hesitate to copy what is done in the coreutils :)