Skip to content

Comments are only sent when GNU/BFS test compatibility changes.#407

Merged
sylvestre merged 5 commits into
uutils:mainfrom
hanbings:improve-ci
Jun 28, 2024
Merged

Comments are only sent when GNU/BFS test compatibility changes.#407
sylvestre merged 5 commits into
uutils:mainfrom
hanbings:improve-ci

Conversation

@hanbings

@hanbings hanbings commented Jun 24, 2024

Copy link
Copy Markdown
Collaborator

Tested in fork, this change may still only take effect after being merged.

@codecov

codecov Bot commented Jun 24, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.31%. Comparing base (f2202dc) to head (ac4ef9d).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #407   +/-   ##
=======================================
  Coverage   65.31%   65.31%           
=======================================
  Files          34       34           
  Lines        3941     3941           
  Branches      903      903           
=======================================
  Hits         2574     2574           
  Misses       1001     1001           
  Partials      366      366

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sylvestre
sylvestre reviewed Jun 24, 2024
View reviewed changes
Comment thread .github/workflows/comment.yml Outdated

console.log(annotationContent);
// check if no changes
let gnuTestReport = annotationContent.includes('Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0');

@sylvestre sylvestre Jun 24, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems a bit fragile. In the json, we don't have the number to do some if > 0 ?

@hanbings hanbings Jun 24, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That might mean getting the results for the master branch in comment.yml and comparing them to bfs-result.json and gnu-result.json? I think this might be a bit repetitive and complicated.

How about changing compare_bfs_result.py to send a Github Actions Annotations using print(f"::warning :: BFS tests no change.") and catch annotation in comment.yml when compatibility is unchanged?

@sylvestre sylvestre Jun 24, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, probably better and easier

@github-actions

github-actions Bot commented Jun 24, 2024

Copy link
Copy Markdown

GNU testsuite comparison:

Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105
Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0

@github-actions

github-actions Bot commented Jun 24, 2024

Copy link
Copy Markdown

GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105

@github-actions

github-actions Bot commented Jun 26, 2024

Copy link
Copy Markdown

GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 718 / PASS: 433 / FAIL: 282 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests No changes
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 182 / SKIP: 1 / FAIL: 105

@sylvestre

sylvestre commented Jun 26, 2024

Copy link
Copy Markdown
Contributor

i guess it isn't ready yet, right ? :)

@hanbings

hanbings commented Jun 26, 2024

Copy link
Copy Markdown
Collaborator Author

Yeah, I haven't tested this code on my fork yet.
I originally wanted to mark this PR as Draft, but Github doesn't seem to show me that button. I'll mention you here when I'm done, thanks! :)

@hanbings

hanbings commented Jun 27, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@sylvestre done.
This is a sample generated during testing: hanbings#19 (comment)
Is there anything else we need to add?

@github-actions

github-actions Bot commented Jun 27, 2024

Copy link
Copy Markdown

GNU testsuite comparison:

Run GNU findutils tests: GNU tests summary = TOTAL: 706 / PASS: 441 / FAIL: 262 / ERROR: 2
Run GNU findutils tests: Changes from main: PASS +0 / FAIL +0 / ERROR +0 / SKIP +0 
Run GNU findutils tests: Gnu tests No changes
Run BFS tests: Changes from main: PASS +0 / SKIP +0 / FAIL +0
Run BFS tests: BFS tests No changes
Run BFS tests: BFS tests summary = TOTAL: 288 / PASS: 186 / SKIP: 1 / FAIL: 101

@sylvestre

sylvestre commented Jun 27, 2024

Copy link
Copy Markdown
Contributor

sorry, looks like i wasn't cleary. What I would like is to have nothing to display when
BFS tests or Gnu tests = No changes

we should only display something when we noticed changes in bfs or gnu tests

@hanbings

hanbings commented Jun 27, 2024

Copy link
Copy Markdown
Collaborator Author

sorry, looks like i wasn't cleary. What I would like is to have nothing to display when BFS tests or Gnu tests = No changes

we should only display something when we noticed changes in bfs or gnu tests

No, actually it does not send comments when it contains No changes. But Github Actions will only execute the workflows file of the default branch, and the logic of whether to send comments is in the comment.yml file, so we need to merge this PR first to see the final effect.

@sylvestre sylvestre merged commit f145469 into uutils:main Jun 28, 2024
@sylvestre

sylvestre commented Jun 28, 2024

Copy link
Copy Markdown
Contributor

ok, let's see :)

@BrewTestBot BrewTestBot mentioned this pull request Jun 29, 2024
Merged
@hanbings hanbings deleted the improve-ci branch July 14, 2024 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sylvestre sylvestre sylvestre left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hanbings @sylvestre