Implement -noleaf#414
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #414 +/- ##
==========================================
+ Coverage 65.55% 65.58% +0.03%
==========================================
Files 34 34
Lines 3942 3952 +10
Branches 902 904 +2
==========================================
+ Hits 2584 2592 +8
Misses 1002 1002
- Partials 356 358 +2 ☔ View full report in Codecov by Sentry. |
|
Commit 38322c0 has GNU testsuite comparison: |
sylvestre
reviewed
Jul 8, 2024
Contributor
|
LGTM |
|
Commit e9fcdaf has GNU testsuite comparison: |
Collaborator
Author
Sound like a perfect idea, we cannot assume that every user will review the code to determine compatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use the walkdir library for directory traversal in our codebase, and the current predicates are all secondary filtering on the results returned by walkdir. So I guess
-noleafwill not bring any optimization (unlesswalkdirincludes this optimization, to be honest I don't know much aboutwalkdirand didn't find any related functions in their documentation).The current code only contains compatibility code.
Closes #376