Skip to content

options return true#417

Merged
sylvestre merged 2 commits into
uutils:mainfrom
tavianator:options-return-true
Jul 11, 2024
Merged

options return true#417
sylvestre merged 2 commits into
uutils:mainfrom
tavianator:options-return-true

Conversation

@tavianator

Copy link
Copy Markdown
Contributor
  • find: Options like -maxdepth return true
  • find: Stop parsing after we see -help or -version

Previously, this would give an error:

    $ find -maxdepth 0 -a -print
    Error: invalid expression; you have used a binary operator '-a' with nothing before it.

Now, options are treated like other primary expressions:

    $ find -maxdepth 0 -a print
    .
GNU find accepts things like

    $ find \( -help -foo -not
@codecov

codecov Bot commented Jul 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.74%. Comparing base (9c11f11) to head (e9634f1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #417      +/-   ##
==========================================
+ Coverage   65.57%   65.74%   +0.16%     
==========================================
  Files          34       34              
  Lines        3951     3953       +2     
  Branches      905      905              
==========================================
+ Hits         2591     2599       +8     
+ Misses       1002      998       -4     
+ Partials      358      356       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre requested a review from hanbings July 11, 2024 07:05

@hanbings hanbings left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks.

@sylvestre sylvestre merged commit 7f4423e into uutils:main Jul 11, 2024
@tavianator tavianator deleted the options-return-true branch July 28, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants