xargs: add support for -E option#593
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #593 +/- ##
==========================================
+ Coverage 88.88% 91.69% +2.81%
==========================================
Files 31 31
Lines 6297 6179 -118
Branches 324 327 +3
==========================================
+ Hits 5597 5666 +69
+ Misses 578 392 -186
+ Partials 122 121 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I'll add more test coverage and post an update. |
cakebaker
reviewed
Nov 18, 2025
Comment on lines
+659
to
+671
| match self.reader.next() { | ||
| Err(e) => Err(e), | ||
| Ok(arg) => match arg { | ||
| None => Ok(None), | ||
| Some(arg) => { | ||
| if arg.arg == self.eof_delimiter { | ||
| Ok(None) | ||
| } else { | ||
| Ok(Some(arg)) | ||
| } | ||
| } | ||
| }, | ||
| } |
Contributor
There was a problem hiding this comment.
I think you can simplify the code a bit by using map. Something like:
Suggested change
| match self.reader.next() { | |
| Err(e) => Err(e), | |
| Ok(arg) => match arg { | |
| None => Ok(None), | |
| Some(arg) => { | |
| if arg.arg == self.eof_delimiter { | |
| Ok(None) | |
| } else { | |
| Ok(Some(arg)) | |
| } | |
| } | |
| }, | |
| } | |
| self.reader.next().map(|opt| { | |
| opt.and_then(|arg| { | |
| if arg.arg == self.eof_delimiter { | |
| None | |
| } else { | |
| Some(arg) | |
| } | |
| }) | |
| }) |
Contributor
|
Thanks for your PR! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.