refactor: remove IE8 specific changes#5041
Conversation
|
The best part is that this change makes the min.gz file 0.16KB larger. |
| "presets": [ | ||
| "es3", | ||
| ["es2015", { | ||
| "loose": true |
There was a problem hiding this comment.
don't we only do loose for IE < 11 as well?
There was a problem hiding this comment.
we don't need loose mode but the filesize output from loose mode is smaller compared to regular.
| } | ||
| return null; | ||
| }()); | ||
| export const IS_IE8 = (/MSIE\s8\.0/).test(USER_AGENT); |
There was a problem hiding this comment.
I am not sure if we should remove this code
There was a problem hiding this comment.
yeah, maybe we should keep these, not sure.
There was a problem hiding this comment.
Actually, I think I'm inclined to leave it out since we don't need any IE8 checks and we can always add it back in if necessary.
|
could also be good to mention in the title that this removes old android code as well. |
|
I'll add the android thing as part of the BREAKING CHANGE flag in the commit message. |
|
actually, I think the IE8 CSS stuff can come in a separate PR. |
|
same with the vttjs update. |
|
well, did the css changes. font stuff and vttjs stuff can and should come in separate PRs |
|
I think we use them in a lot of places internally, and new techs it could be useful |
|
A bit hesitant to make changes to URL.js. Not touching events.js, I think the try/catch in a few places should stay just to be extra safe, the "ie6" SO link for getAbsoluteURL still applies, since it still uses the same technique. |
|
We have a few things here that related to IE and no media player, I'm inclined to leave the try/catches for them in. I'll update them to just mention IE in general, rather than IE9 or something. |
|
also, the two flash related items might be considered in a separate PR/issue. |
|
Some of what you linked was already fixed. Most of what I haven't changed is because it isn't worth changing at least not for the PR because it involves unnecessary refactoring. |
|
ok well the code still lgtm, I added check marks to my previous comment, feel free to check off what's done and I will move everything else into a separate issue. |
|
When having a video-js embed with a class attribute, as part of the changes to remove old IE support (#5041), we overwrote our addition of the video-js class when it was missing. Instead, we want to make sure that we don't override the class names again since they are already set up correctly. Fixes videojs/http-streaming#100
When having a video-js embed with a class attribute, as part of the changes to remove old IE support (#5041), we overwrote our addition of the video-js class when it was missing. Instead, we want to make sure that we don't override the class names again since they are already set up correctly. Fixes videojs/http-streaming#100
3 participants
BREAKING CHANGE: remove IE8 specific JavaScript and CSS code. Remove Android 2.3 workaround.
TODO: