feat: Clicking live display seeks to live edge, improved live UI#5499
feat: Clicking live display seeks to live edge, improved live UI#5499brandonocasey wants to merge 5 commits into
Conversation
| @include flex(auto); | ||
| font-size: 1em; | ||
| line-height: 3em; | ||
| font-size: 1.5em; |
There was a problem hiding this comment.
The text was very small in relation to the icons on the control bar, I bumped it up a tiny bit.
There was a problem hiding this comment.
Unfortunately, this means that the LIVE display is now inconsistent with the size of other text in the control bar like the various time displays. I would leave this as is and we should open an issue to look into increase the text size.
| * @extends Component | ||
| */ | ||
| class LiveDisplay extends Component { | ||
| class LiveDisplay extends ClickableComponent { |
There was a problem hiding this comment.
This probably should be a Button, if possible.
brandonocasey
force-pushed
the
feat/live-updates
branch
from
8462181 to
09e774e
Compare
brandonocasey
force-pushed
the
feat/live-updates
branch
from
4da9701 to
6a7cc35
Compare
brandonocasey
force-pushed
the
feat/live-updates
branch
from
6a7cc35 to
3678963
Compare
|
Is a lot of LiveDisplay stays around in #5511? Also, sorry for realizing this so late in the game but I wonder if these updated to the LiveDisplay should be a new component? I think the changes, particularly to the UI of it, may be big enough that it'll cause issues if anyone relied on the LiveDisplay as it exists currently. |
|
I am going to close this PR and make future changes in the other live pr (going to rename that pr to liveui). I will work on moving all of the changes to another component something like |
3 participants
Changes