Skip to content

Correct error type number matches#5566

Merged
gkatsev merged 1 commit into
masterfrom
first-timers-error-types
Nov 9, 2018
Merged

Correct error type number matches#5566
gkatsev merged 1 commit into
masterfrom
first-timers-error-types

Conversation

@bartlomein

Copy link
Copy Markdown
Contributor

Description

Fixed as was specified in the issue.

Specific Changes proposed

Changes as specified.

Requirements Checklist

  • [ X ] Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

@welcome

welcome Bot commented Nov 9, 2018

Copy link
Copy Markdown

💖 Thanks for opening this pull request! 💖

Things that will help get your PR across the finish line:

  • Run npm run lint -- --errors locally to catch formatting errors earlier.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@gkatsev gkatsev mentioned this pull request Nov 9, 2018
7 tasks
@gkatsev gkatsev merged commit 441f0e1 into master Nov 9, 2018
@welcome

welcome Bot commented Nov 9, 2018

Copy link
Copy Markdown

Congrats on merging your first pull request! 🎉🎉🎉

@gkatsev gkatsev deleted the first-timers-error-types branch November 9, 2018 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants