fix: liveui tweaks#5650
Merged
Merged
Conversation
brandonocasey
force-pushed
the
fix/liveui-tweaks
branch
from
7974551 to
7ebe0d7
Compare
gkatsev
reviewed
Dec 5, 2018
Member
|
This is a great change towards making the button seek to "live" asap. In another PR, we probably need to do @gesinger's suggestion of looseing up what "at edge" means as I can see the inidicator toggling between grey and red during regular playback. |
gkatsev
approved these changes
Dec 6, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
seekablevalue in the video element, so we use that to seek to live, rather than waiting for a seekable end change.