The Wayback Machine - https://web.archive.org/web/20220930073147/https://github.com/pythonnet/pythonnet/pull/1662
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup PyBuffer a bit #1662

Merged
merged 1 commit into from Jan 6, 2022
Merged

Conversation

lostmsu
Copy link
Member

@lostmsu lostmsu commented Jan 6, 2022

What does this implement/fix? Explain your changes.

  • better finalizer, that actually calls PyBuffer_Release
  • improved input parameter handling for common routines
  • added support for copying data to/from large Python buffers

Does this close any currently open issues?

fixes #1556

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change

- better finalizer, that actually calls PyBuffer_Release
- improved input parameter handling for common routines
- added support for copying data to/from large Python buffers

fixes pythonnet#1556
filmor
filmor approved these changes Jan 6, 2022
@lostmsu lostmsu merged commit 88850f5 into pythonnet:master Jan 6, 2022
16 checks passed
@lostmsu lostmsu deleted the cleanup/PyBuffer branch Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants