[E-1] 10-Retriever / 10-Kiwi-BM25-Retriever #415#509
Merged
teddylee777 merged 2 commits intoFeb 1, 2025
Merged
Conversation
Contributor
|
죄송합니다, 정기님! 더불어, 먼저 올려주신 수정 사항에 BM25에 backtick 넣으신 건 빼셔도 됩니다! 번거롭게 해드려서 죄송합니다 🙇 |
Contributor
|
@jeongkpa 님 준의님 코멘트 확인 부탁드립니다:) 수정 후 멘션+코멘트 주시면 감사하겠습니다!! |
Contributor
Author
|
@BokyungisaGod @ee-juni 수정했습니다! 코멘트 감사합니다!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
{PR Message - Write freely, remove this bracket if unnecessary}
Author Checklist
PR Title Format: I have confirmed that the PR title follows the correct format. (e.g., [N-2] 07-Text Splitter / 07-RecursiveCharacterTextSplitter)
Committed Files: I have ensured that no unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) are included. These files are not allowed.
(Optional) Related Issue: If this PR is linked to an issue, I have referenced the issue number in the PR message. (e.g., Fixes Update 01-PromptTemplate.ipynb #123)
❌ Do not include unnecessary files (e.g., .bin, .gitignore, poetry.lock, pyproject.toml) or other people's code. If included, close the PR and create a new PR.
Review Template (Intial PR)
If no one reviews your PR within a few days, please @-mention one of teddylee777, musangk, BAEM1N
@ee-juni @BokyungisaGod 님 #415 커밋 내역들 모두 확인했고, 수정돼있는 부분은 유지하고 수정 안돼있는 typo 수정 후 리뷰 부탁드립니다.