Skip to content

Remove path manipulation antipatterns#1064

Merged
edwinyyyu merged 1 commit into
MemMachine:mainfrom
edwinyyyu:antipatterns
Feb 9, 2026
Merged

Remove path manipulation antipatterns#1064
edwinyyyu merged 1 commit into
MemMachine:mainfrom
edwinyyyu:antipatterns

Conversation

@edwinyyyu

@edwinyyyu edwinyyyu commented Feb 6, 2026

Copy link
Copy Markdown
Contributor

Purpose of the change

Blocks #1052

Description

Remove path manipulation antipatterns that affect source refactor.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (does not change functionality, e.g., code style improvements, linting)
  • Documentation update
  • Project Maintenance (updates to build scripts, CI, etc., that do not affect the main project)
  • Security (improves security without changing functionality)

How Has This Been Tested?

If there are any existing tests, they should pass.

  • Unit Test
  • Integration Test
  • End-to-end Test
  • Test Script (please provide)
  • Manual verification (list step-by-step instructions)

Checklist

  • I have signed the commit(s) within this pull request
  • My code follows the style guidelines of this project (See STYLE_GUIDE.md)
  • I have performed a self-review of my own code
  • I have commented my code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Maintainer Checklist

  • Confirmed all checks passed
  • Contributor has signed the commit(s)
  • Reviewed the code
  • Run, Tested, and Verified the change(s) work as expected

@edwinyyyu

edwinyyyu commented Feb 7, 2026

Copy link
Copy Markdown
Contributor Author

Scope too large. It's hard to tell what will break because the most reasonable solutions are to make all scripts run as modules with -m or refactoring the script directories, which people will not like. Reducing to only imports from memmachine packages.

Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
@edwinyyyu edwinyyyu marked this pull request as ready for review February 9, 2026 18:02
@edwinyyyu edwinyyyu merged commit 75eb4ef into MemMachine:main Feb 9, 2026
53 of 54 checks passed
SarahScargall pushed a commit to SarahScargall/MemMachine that referenced this pull request Feb 9, 2026
Signed-off-by: Edwin Yu <edwinyyyu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants