dms-2024-i3-r2#87
Merged
Merged
Conversation
Bump nokogiri to 1.16.5 Bump rexml to 3.2.8
* Initial commit to new Leeds CRC code * Leeds CRC refactoring QA final code * rubocop fixes * rubocop fixes * corrected script command * Review comment , moved batch level code * PR review comments changes * More comments added * PR review comments changes
* remove testscope and teststatus * Fake barts handler to link Lynch data * removed 'barts' name from importer, replaced with 'adhoc' * Added provided X26 for adhoc Lynch data * Corrected name for record in tests --------- Co-authored-by: lauramccluskey <laura.mccluskey3@nhs.net> Co-authored-by: Nichola Imeson <nichola.imeson@nhs.net>
* re-adding changes after erroneous git rebase * rucocop changes added * fixed failing test * made code review changes, removed zygosity * made code review changes, removed zygosity * adding final change from PR and fix teststatus issue * importer wasn't assigning moleculsr testing type - corrected this * made PR changes, rubocop fixes, added tests * making test_type mapping case insensitive * removed barts mapping, added extra line to constants * Rubocop indentation fixes --------- Co-authored-by: shilpigoel <shilpi.goel1@nhs.net>
* inital commit of rewriting St George's importer for new format * updates to George's importer for new format * continue rewriting st georges importer * continue rewriting st georges importer * update tests * tidy up code * rubocop changes * more code tidying * more working progress for st george importer * update process_variants * continue work on st georges importer new format * add genes from panels * added filter to import only files with HBOC in filename * added filter to import only files with HBOC in filename * add rubocop changes * continue updating st georges code and tests * more tidying of st georges code * more tidying of st georges code * add more comments to st georges code * add more comments to st georges code * update to unittests * add more unittests * add more unittests * added in old st georges importer and additional import method for old format data * added in check for SRI starting letter, added back in the old st georges tests * Corrected 'gene (other)' typo in handler and tests * update code to get the panel genes * fixed old st george importer tests * added a couple of comments * fix errors * made fixes to regular expressions and r208 processing * fixed tests * update test names * tidy code and run rubocop * run rubocop on st georges tests * removed counter logic from duplicate_genotype_targeted * rubocop and fix rule difference * fix rule difference and update unittests * run rubocop * update tests * update tests * update tests * made some rubocop fixes * final rubocop fixes * fix errors * update st georges rules * tidy code and fix todos * fix errors * make changes from code review * make changes from code review * fix bug and make changes from code review * make changes from code review * make changes from code review and remove zygosity * remove unnecessary parameter * match name of class in tests to name of file * make changes from code review * updates to rules * added in BRCA_INGER_MAP to constants, fixed teststatus issue * rubocop corrections * Rewrote Test status method for full screen cases * added rule change and relevant test to it as per review comment * made test type mapping case insensitive --------- Co-authored-by: Nichola Imeson <nichola.imeson@nhs.net> Co-authored-by: Nichola Imeson <nichiola.imeson@nhs.net> Co-authored-by: shilpigoel <shilpi.goel1@nhs.net>
* importer fix for old st george hander * removed binding.pry * Added test * corrected whitespace issues * Addition to process_fields test --------- Co-authored-by: shilpigoel <shilpi.goel1@nhs.net>
ollietulloch
approved these changes
Jun 24, 2024
ollietulloch
left a comment
Contributor
There was a problem hiding this comment.
LGTM, assuming tests are happy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.