remove a superfluous <space> character before '^\' by rjc · Pull Request #1 · NetBSD/src

rjc · 2017-10-18T22:06:08Z

This fixes alignment in vi's 'viusage' command.

This has been fixed upstream and in OpenBSD.

This fixes alignment in vi's 'viusage' command. This has been fixed [upstream](http://repo.or.cz/nvi.git/commit/4703128e5fd17a020e111baefd1bcc96c3062de2) and in [OpenBSD](https://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/vi/vi/v_cmd.c.diff?r1=1.4&r2=1.5&sortby=date&f=h).

From rjc via #1

From rjc via NetBSD/src#1

The cp_old array is allocated with malloc(3) and its pointer is passed to percentages64(). In this function there happens a calculation of total_change, which value depends on the value inside the unitialized cp_old[] array. ==26662==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x268a2c in percentages64 /usr/src/external/bsd/top/bin/../dist/machine/m_netbsd.c:1341:6 #1 0x26748b in get_system_info /usr/src/external/bsd/top/bin/../dist/machine/m_netbsd.c:478:6 #2 0x25518e in do_display /usr/src/external/bsd/top/bin/../dist/top.c:507:5 #3 0x253038 in main /usr/src/external/bsd/top/bin/../dist/top.c:975:2 #4 0x21cad1 in ___start (/usr/bin/top+0x1cad1) SUMMARY: MemorySanitizer: use-of-uninitialized-value /usr/src/external/bsd/top/bin/../dist/machine/m_netbsd.c:1341:6 in percentages64 Exiting Fix this issue by changling malloc(3) with calloc(3). Detected with Memory Sanitizer during the integration of sanitizers with the NetBSD basesystem. Reported by <Yang Zheng>

access. Example of output: kASan: Unauthorized Access In 0xffffffff80e6219c: Addr 0xffffbb007a39fd03 [1 byte, read] #0 0xffffffff80e6219c in ras_purgeall <netbsd> #1 0xffffffff80e62330 in sys_rasctl <netbsd> #2 0xffffffff80265008 in syscall <netbsd> (I manually added a one-byte stack read overflow in rasctl to demonstrate.)

[ 1.044878] kASan: Unauthorized Access In 0xffffffff804ec7e2: Addr 0xffffffff818a51e4 [2 bytes, read] [ 1.044878] #0 0xffffffff804ec7e2 in mskc_probe <netbsd> [ 1.044878] #1 0xffffffff80e92a77 in mapply <netbsd> [ 1.044878] #2 0xffffffff80e92e5f in config_search_loc <netbsd> [ 1.044878] #3 0xffffffff80e93fb5 in config_found_sm_loc <netbsd> [ 1.044878] #4 0xffffffff802ca9ea in pci_probe_device <netbsd> [ 1.044878] #5 0xffffffff802cad97 in pci_enumerate_bus <netbsd> [ 1.044878] #6 0xffffffff802caf00 in pcirescan <netbsd> [ 1.044878] #7 0xffffffff802cb1ee in pciattach <netbsd> [ 1.044878] #8 0xffffffff80e93e5b in config_attach_loc <netbsd> [ 1.044878] #9 0xffffffff80e93fce in config_found_sm_loc <netbsd> [ 1.044878] #10 0xffffffff80271212 in mp_pci_scan <netbsd> [ 1.044878] #11 0xffffffff8022d9ee in mainbus_attach <netbsd> [ 1.044878] #12 0xffffffff80e93e5b in config_attach_loc <netbsd> [ 1.044878] #13 0xffffffff8021e38b in cpu_configure <netbsd> [ 1.044878] #14 0xffffffff814a7068 in main <netbsd>

ifconfig gif0 create ifconfig gif0 up [ 50.682919] kASan: Unauthorized Access In 0xffffffff80f22655: Addr 0xffffffff81b997a0 [8 bytes, read] [ 50.682919] #0 0xffffffff8021ce6a in kasan_memcpy <netbsd> [ 50.692999] #1 0xffffffff80f22655 in m_copyback_internal <netbsd> [ 50.692999] #2 0xffffffff80f22e81 in m_copyback <netbsd> [ 50.692999] #3 0xffffffff8103109a in rt_msg1 <netbsd> [ 50.692999] #4 0xffffffff8159109a in compat_70_rt_newaddrmsg1 <netbsd> [ 50.692999] #5 0xffffffff81031b0f in rt_newaddrmsg <netbsd> [ 50.692999] #6 0xffffffff8102c35e in rt_ifa_addlocal <netbsd> [ 50.692999] #7 0xffffffff80a5287c in in6_update_ifa1 <netbsd> [ 50.692999] #8 0xffffffff80a54149 in in6_update_ifa <netbsd> [ 50.692999] #9 0xffffffff80a59176 in in6_ifattach <netbsd> [ 50.692999] #10 0xffffffff80a56dd4 in in6_if_up <netbsd> [ 50.692999] #11 0xffffffff80fc5cb8 in if_up_locked <netbsd> [ 50.703622] #12 0xffffffff80fcc4c1 in ifioctl_common <netbsd> [ 50.703622] #13 0xffffffff80fde694 in gif_ioctl <netbsd> [ 50.703622] #14 0xffffffff80fcdb1f in doifioctl <netbsd>

This complements change in revision 1.140

sys/dev/usb/uhub.c: revision 1.140 sys/dev/usb/uhub.c: revision 1.141 sys/dev/usb/usb_subr.c: revision 1.228 Make USB port numbers display consistent Make sure USB ports numbers are displayed with the first one as number one and not number zero when rescanning bus. The change makes the display consistent with the display at boot time USB discovery. While we are there, make port iteration consistent everywhere in the code, always starting at one instead of zero. - Make USB port iteration code consistent, always startint at port #1 This complements change in revision 1.140

…ngs. [ 223.896199] kleak: Possible leak in copyout: [len=32, leaked=8] [ 223.906430] #0 0xffffffff80224d0a in kleak_note <netbsd> [ 223.906430] #1 0xffffffff80224d8a in kleak_copyout <netbsd> [ 223.918363] #2 0xffffffff80b1e26c in copyoutpsstrs <netbsd> [ 223.926560] #3 0xffffffff80b1e331 in copyoutargs <netbsd> [ 223.936216] #4 0xffffffff80b21768 in execve_runproc <netbsd> [ 223.946225] #5 0xffffffff80b21cc9 in execve1 <netbsd> [ 223.946225] #6 0xffffffff8025a89c in sy_call <netbsd> [ 223.956225] #7 0xffffffff8025aace in sy_invoke <netbsd> [ 223.966232] #8 0xffffffff8025ab54 in syscall <netbsd>

[ 224.006287] kleak: Possible leak in copyout: [len=920, leaked=92] [ 224.016977] #0 0xffffffff80224d0a in kleak_note <netbsd> [ 224.026268] #1 0xffffffff80224d8a in kleak_copyout <netbsd> [ 224.026268] #2 0xffffffff802224b5 in sendsig_siginfo <netbsd> [ 224.036261] #3 0xffffffff80b51564 in sendsig <netbsd> [ 224.046475] #4 0xffffffff80b51282 in postsig <netbsd> [ 224.046475] #5 0xffffffff80b2fc5d in lwp_userret <netbsd> [ 224.056273] #6 0xffffffff8025a951 in mi_userret <netbsd> [ 224.066277] #7 0xffffffff8025ab89 in syscall <netbsd>

…Looks like there are other leaks related to timeval in this file. [ 133.414352] kleak: Possible leak in copyout: [len=16, leaked=4] [ 133.414352] #0 0xffffffff80224d0a in kleak_note <netbsd> [ 133.424360] #1 0xffffffff80224d8a in kleak_copyout <netbsd> [ 133.434361] #2 0xffffffff80b5fd79 in sys___gettimeofday50 <netbsd> [ 133.434361] #3 0xffffffff8025a89c in sy_call <netbsd> [ 133.444351] #4 0xffffffff8025aace in sy_invoke <netbsd> [ 133.454365] #5 0xffffffff8025ab54 in syscall <netbsd>

[ 287.537676] kleak: Possible leak in copyout: [len=40, leaked=4] [ 287.537676] #0 0xffffffff80b7c41a in kleak_note <netbsd> [ 287.547673] #1 0xffffffff80b7c49a in kleak_copyout <netbsd> [ 287.557677] #2 0xffffffff80b1d32d in kqueue_scan.isra.1.constprop.2 <netbsd> [ 287.557677] #3 0xffffffff80b1dc6a in kevent1 <netbsd> [ 287.567683] #4 0xffffffff80b1dcb0 in sys___kevent50 <netbsd> [ 287.567683] #5 0xffffffff8025ab3c in sy_call <netbsd> [ 287.577688] #6 0xffffffff8025ad6e in sy_invoke <netbsd> [ 287.587693] #7 0xffffffff8025adf4 in syscall <netbsd>

…val. [ 738.451860] kleak: Possible leak in copyout: [len=32, leaked=8] [ 738.481840] #0 0xffffffff80b7c42a in kleak_note <netbsd> [ 738.491821] #1 0xffffffff80b7c4aa in kleak_copyout <netbsd> [ 738.501806] #2 0xffffffff80b6154e in sys___getitimer50 <netbsd> [ 738.511778] #3 0xffffffff80b61e39 in sys___setitimer50 <netbsd> [ 738.521781] #4 0xffffffff8025ab3c in sy_call <netbsd> [ 738.521781] #5 0xffffffff8025ad6e in sy_invoke <netbsd> [ 738.531808] #6 0xffffffff8025adf4 in syscall <netbsd>

[ 944.607323] kleak: Possible leak in copyout: [len=176, leaked=2] [ 944.617335] #0 0xffffffff80b7c44a in kleak_note <netbsd> [ 944.627332] #1 0xffffffff80b7c4ca in kleak_copyout <netbsd> [ 944.627332] #2 0xffffffff80c91698 in sysctl_iflist_if <netbsd> [ 944.637336] #3 0xffffffff80c91d3c in sysctl_iflist <netbsd> [ 944.647343] #4 0xffffffff80c93855 in sysctl_rtable <netbsd> [ 944.647343] #5 0xffffffff80b5b328 in sysctl_dispatch <netbsd> [ 944.657346] #6 0xffffffff80b5b62e in sys___sysctl <netbsd> [ 944.667354] #7 0xffffffff8025ab3c in sy_call <netbsd> [ 944.667354] #8 0xffffffff8025ad6e in sy_invoke <netbsd> [ 944.677365] #9 0xffffffff8025adf4 in syscall <netbsd>

Possible info leak: [len=1056, leaked=931] #0 0xffffffff80bad351 in kleak_copyout #1 0xffffffff80b2cf64 in uvm_swap_stats.part.1 #2 0xffffffff80b2d38d in uvm_swap_stats #3 0xffffffff80b2d43c in sys_swapctl #4 0xffffffff80259b82 in syscall

sys/kern/kern_exec.c: revision 1.462 Fix stack info leak. There are 2x4 bytes of padding in struct ps_strings. [ 223.896199] kleak: Possible leak in copyout: [len=32, leaked=8] [ 223.906430] #0 0xffffffff80224d0a in kleak_note <netbsd> [ 223.906430] #1 0xffffffff80224d8a in kleak_copyout <netbsd> [ 223.918363] #2 0xffffffff80b1e26c in copyoutpsstrs <netbsd> [ 223.926560] #3 0xffffffff80b1e331 in copyoutargs <netbsd> [ 223.936216] #4 0xffffffff80b21768 in execve_runproc <netbsd> [ 223.946225] #5 0xffffffff80b21cc9 in execve1 <netbsd> [ 223.946225] #6 0xffffffff8025a89c in sy_call <netbsd> [ 223.956225] #7 0xffffffff8025aace in sy_invoke <netbsd> [ 223.966232] #8 0xffffffff8025ab54 in syscall <netbsd>

sys/net/rtsock.c: revision 1.244 Fix kernel info leak. There are 2 bytes of padding in struct if_msghdr. [ 944.607323] kleak: Possible leak in copyout: [len=176, leaked=2] [ 944.617335] #0 0xffffffff80b7c44a in kleak_note <netbsd> [ 944.627332] #1 0xffffffff80b7c4ca in kleak_copyout <netbsd> [ 944.627332] #2 0xffffffff80c91698 in sysctl_iflist_if <netbsd> [ 944.637336] #3 0xffffffff80c91d3c in sysctl_iflist <netbsd> [ 944.647343] #4 0xffffffff80c93855 in sysctl_rtable <netbsd> [ 944.647343] #5 0xffffffff80b5b328 in sysctl_dispatch <netbsd> [ 944.657346] #6 0xffffffff80b5b62e in sys___sysctl <netbsd> [ 944.667354] #7 0xffffffff8025ab3c in sy_call <netbsd> [ 944.667354] #8 0xffffffff8025ad6e in sy_invoke <netbsd> [ 944.677365] #9 0xffffffff8025adf4 in syscall <netbsd>

sys/kern/kern_event.c: revision 1.104 Fix kernel info leak. There are 4 bytes of padding in struct kevent. [ 287.537676] kleak: Possible leak in copyout: [len=40, leaked=4] [ 287.537676] #0 0xffffffff80b7c41a in kleak_note <netbsd> [ 287.547673] #1 0xffffffff80b7c49a in kleak_copyout <netbsd> [ 287.557677] #2 0xffffffff80b1d32d in kqueue_scan.isra.1.constprop.2 <netbsd> [ 287.557677] #3 0xffffffff80b1dc6a in kevent1 <netbsd> [ 287.567683] #4 0xffffffff80b1dcb0 in sys___kevent50 <netbsd> [ 287.567683] #5 0xffffffff8025ab3c in sy_call <netbsd> [ 287.577688] #6 0xffffffff8025ad6e in sy_invoke <netbsd> [ 287.587693] #7 0xffffffff8025adf4 in syscall <netbsd>

+ Possible info leak: [len=32, leaked=16] | #0 0xffffffff80baf3a7 in kleak_copyout | #1 0xffffffff80b940f8 in sys___timer_settime50 | #2 0xffffffff80259c42 in syscall

sys/net/rtsock.c: revision 1.244 (adapted) Fix kernel info leak. There are 2 bytes of padding in struct if_msghdr. [ 944.607323] kleak: Possible leak in copyout: [len=176, leaked=2] [ 944.617335] #0 0xffffffff80b7c44a in kleak_note <netbsd> [ 944.627332] #1 0xffffffff80b7c4ca in kleak_copyout <netbsd> [ 944.627332] #2 0xffffffff80c91698 in sysctl_iflist_if <netbsd> [ 944.637336] #3 0xffffffff80c91d3c in sysctl_iflist <netbsd> [ 944.647343] #4 0xffffffff80c93855 in sysctl_rtable <netbsd> [ 944.647343] #5 0xffffffff80b5b328 in sysctl_dispatch <netbsd> [ 944.657346] #6 0xffffffff80b5b62e in sys___sysctl <netbsd> [ 944.667354] #7 0xffffffff8025ab3c in sy_call <netbsd> [ 944.667354] #8 0xffffffff8025ad6e in sy_invoke <netbsd> [ 944.677365] #9 0xffffffff8025adf4 in syscall <netbsd>

sys/kern/kern_exec.c: revision 1.462 Fix stack info leak. There are 2x4 bytes of padding in struct ps_strings. [ 223.896199] kleak: Possible leak in copyout: [len=32, leaked=8] [ 223.906430] #0 0xffffffff80224d0a in kleak_note <netbsd> [ 223.906430] #1 0xffffffff80224d8a in kleak_copyout <netbsd> [ 223.918363] #2 0xffffffff80b1e26c in copyoutpsstrs <netbsd> [ 223.926560] #3 0xffffffff80b1e331 in copyoutargs <netbsd> [ 223.936216] #4 0xffffffff80b21768 in execve_runproc <netbsd> [ 223.946225] #5 0xffffffff80b21cc9 in execve1 <netbsd> [ 223.946225] #6 0xffffffff8025a89c in sy_call <netbsd> [ 223.956225] #7 0xffffffff8025aace in sy_invoke <netbsd> [ 223.966232] #8 0xffffffff8025ab54 in syscall <netbsd>

sys/kern/kern_sig.c: revision 1.350 Fix kernel info leak, 4 bytes of padding at the end of struct sigaction. + Possible info leak: [len=32, leaked=4] | #0 0xffffffff80baf327 in kleak_copyout | #1 0xffffffff80bd9ca8 in sys___sigaction_sigtramp | #2 0xffffffff80259c42 in syscall

sys/kern/kern_exit.c: revision 1.273 Fix info leak. There is one branch where 'status' is not initialized at all. + Possible info leak: [len=4, leaked=4] | #0 0xffffffff80baf397 in kleak_copyout | #1 0xffffffff80b56d0c in sys_wait6 | #2 0xffffffff80259c42 in syscall

sys/kern/kern_sig.c: revision 1.350 Fix kernel info leak, 4 bytes of padding at the end of struct sigaction. + Possible info leak: [len=32, leaked=4] | #0 0xffffffff80baf327 in kleak_copyout | #1 0xffffffff80bd9ca8 in sys___sigaction_sigtramp | #2 0xffffffff80259c42 in syscall

should just set _pad to zero on LP64? + Possible info leak: [len=40, leaked=4] | #0 0xffffffff80baf397 in kleak_copyout | #1 0xffffffff80bda817 in sigtimedwait1 | #2 0xffffffff80bdab95 in sys_____sigtimedwait50 | #3 0xffffffff80259c42 in syscall

sys/dev/pci/pci_subr.c: revision 1.210 sys/dev/pci/pci_subr.c: revision 1.207 sys/dev/pci/pcireg.h: revision 1.143 sys/dev/pci/pci_subr.c: revision 1.208 sys/dev/pci/pcireg.h: revision 1.144 sys/dev/pci/pci_subr.c: revision 1.209 sys/dev/pci/pcireg.h: revision 1.145 sys/dev/pci/pcireg.h: revision 1.146 Decode PCI Enhanced Allocation. The register offset of the mask and pending register is depend on the 64bit address capable bit, so fix the definition of PCI MSI vector mask and pending register. This problem was not a real bug because PCI_MSI{MASK,PENDING} were not used from anywhere. The downstream port of PCIe switch is not a root port, so don't print root port related register. For example, Intel 63xxESB controller's downstream port device was printed by pcictl(8) with this bug: ----------------------------- PCI configuration registers: Common header: 0x00: 0x35108086 0x00100147 0x06040001 0x00010010 Vendor Name: Intel (0x8086) Device Name: 63xxESB PCI Express Downstream Port #1 (0x3510) (snip) Capability register at 0x44 <============= type: 0x10 (PCI Express) Capability register at 0x60 <============= 0x60 - 0x44 = 0x1c type: 0x05 (MSI) Capability register at 0x70 type: 0x01 (Power Management) Capability register at 0x80 type: 0x0d (Subsystem vendor ID) (snip) PCI Message Signaled Interrupt Message Control register: 0x0080 MSI Enabled: off Multiple Message Capable: no (1 vector) Multiple Message Enabled: off (1 vector) 64 Bit Address Capable: on Per-Vector Masking Capable: off Extended Message Data Capable: off Extended Message Data Enable: off Message Address (lower) register: 0x00000000 Message Address (upper) register: 0x00000000 Message Data register: 0x0000 (snip) PCI Express Capabilities Register (snip) Root Control Register: 0x7005 <=== 0x7005 is the first two byte SERR on Correctable Error Enable: on of the MSI capability structure SERR on Non-Fatal Error Enable: off SERR on Fatal Error Enable: on PME Interrupt Enable: off CRS Software Visibility Enable: off Root Capability Register: 0x0080 CRS Software Visibility: off Root Status Register: 0x00000000 PME Requester ID: 0x0000 PME was asserted: off another PME is pending: off Device-dependent header: 0x40: 0x00c00000 0x00616010 0x00000001 0x00005026 | |<- PCIe | 0x50: 0x0203f441 0x10010020 0x00000000 0x004803c0 | ->| 0x60: 0x00807005 0x00000000 0x00000000 0x00000000 |<- MSI ->| 0x70: 0xc8028001 0x00000100 0x00000000 0x00000000 |<- PM ->| 0x80: 0x0000000d 0x00000000 0x00000000 0x00000000 |<- subsystem ID | -------------------------------------- Add new macro PCIE_HAS_ROOTREGS(pcie_devtype) and use it. No functional change. Add new PCIE_HAS_LINKREGS(pcie_devtype) and use it. No functional change.

sys/arch/amd64/amd64/machdep.c: revision 1.321 Fix stack info leak. There is a big padding in struct sigframe_siginfo. [ 224.006287] kleak: Possible leak in copyout: [len=920, leaked=92] [ 224.016977] #0 0xffffffff80224d0a in kleak_note <netbsd> [ 224.026268] #1 0xffffffff80224d8a in kleak_copyout <netbsd> [ 224.026268] #2 0xffffffff802224b5 in sendsig_siginfo <netbsd> [ 224.036261] #3 0xffffffff80b51564 in sendsig <netbsd> [ 224.046475] #4 0xffffffff80b51282 in postsig <netbsd> [ 224.046475] #5 0xffffffff80b2fc5d in lwp_userret <netbsd> [ 224.056273] #6 0xffffffff8025a951 in mi_userret <netbsd> [ 224.066277] #7 0xffffffff8025ab89 in syscall <netbsd>

sys/kern/sys_sig.c: revision 1.47 Fix kernel info leak, 4 bytes of padding in struct _ksiginfo. Maybe we should just set _pad to zero on LP64? + Possible info leak: [len=40, leaked=4] | #0 0xffffffff80baf397 in kleak_copyout | #1 0xffffffff80bda817 in sigtimedwait1 | #2 0xffffffff80bdab95 in sys_____sigtimedwait50 | #3 0xffffffff80259c42 in syscall

Fix similar to: sys/uvm/uvm_swap.c: revision 1.178 Woah man, fix enormous leak. Possible info leak: [len=1056, leaked=931] #0 0xffffffff80bad351 in kleak_copyout #1 0xffffffff80b2cf64 in uvm_swap_stats.part.1 #2 0xffffffff80b2d38d in uvm_swap_stats #3 0xffffffff80b2d43c in sys_swapctl #4 0xffffffff80259b82 in syscall

Similar to: sys/uvm/uvm_swap.c: revision 1.178 Fix kernel info leak in swapctl(2). Possible info leak: [len=1056, leaked=931] #0 0xffffffff80bad351 in kleak_copyout #1 0xffffffff80b2cf64 in uvm_swap_stats.part.1 #2 0xffffffff80b2d38d in uvm_swap_stats #3 0xffffffff80b2d43c in sys_swapctl #4 0xffffffff80259b82 in syscall

Fix similar to: sys/uvm/uvm_swap.c: revision 1.178 Woah man, fix enormous leak. Possible info leak: [len=1056, leaked=931] #0 0xffffffff80bad351 in kleak_copyout #1 0xffffffff80b2cf64 in uvm_swap_stats.part.1 #2 0xffffffff80b2d38d in uvm_swap_stats #3 0xffffffff80b2d43c in sys_swapctl #4 0xffffffff80259b82 in syscall

+ Possible info leak: [len=80, leaked=10] | #0 0xffffffff80bad7a7 in kleak_copyout | #1 0xffffffff8048e71b in netbsd32___msgctl50 | #2 0xffffffff8022fb5b in netbsd32_syscall | #3 0xffffffff802096dd in handle_syscall

sys/kern/kern_time.c: revision 1.191 Fix kernel info leak. There are 2x4 bytes of padding in struct itimerval. [ 738.451860] kleak: Possible leak in copyout: [len=32, leaked=8] [ 738.481840] #0 0xffffffff80b7c42a in kleak_note <netbsd> [ 738.491821] #1 0xffffffff80b7c4aa in kleak_copyout <netbsd> [ 738.501806] #2 0xffffffff80b6154e in sys___getitimer50 <netbsd> [ 738.511778] #3 0xffffffff80b61e39 in sys___setitimer50 <netbsd> [ 738.521781] #4 0xffffffff8025ab3c in sy_call <netbsd> [ 738.521781] #5 0xffffffff8025ad6e in sy_invoke <netbsd> [ 738.531808] #6 0xffffffff8025adf4 in syscall <netbsd>

sys/compat/netbsd32/netbsd32_conv.h: revision 1.37 sys/compat/netbsd32/netbsd32_compat_14.c: revision 1.27 sys/compat/sys/msg.h: revision 1.5 Fix kernel info leaks. + Possible info leak: [len=80, leaked=10] | #0 0xffffffff80bad7a7 in kleak_copyout | #1 0xffffffff8048e71b in netbsd32___msgctl50 | #2 0xffffffff8022fb5b in netbsd32_syscall | #3 0xffffffff802096dd in handle_syscall

sys/kern/kern_time.c: revision 1.190 sys/kern/kern_time.c: revision 1.194 Fix stack info leak. There are 4 bytes of padding in struct timeval. Looks like there are other leaks related to timeval in this file. [ 133.414352] kleak: Possible leak in copyout: [len=16, leaked=4] [ 133.414352] #0 0xffffffff80224d0a in kleak_note <netbsd> [ 133.424360] #1 0xffffffff80224d8a in kleak_copyout <netbsd> [ 133.434361] #2 0xffffffff80b5fd79 in sys___gettimeofday50 <netbsd> [ 133.434361] #3 0xffffffff8025a89c in sy_call <netbsd> [ 133.444351] #4 0xffffffff8025aace in sy_invoke <netbsd> [ 133.454365] #5 0xffffffff8025ab54 in syscall <netbsd> - Fix kernel info leaks.

netbsd-srcmastr pushed a commit that referenced this pull request Oct 22, 2017

Remove superfluous space character.

d5e8b41

From rjc via #1

ryo pushed a commit to IIJ-NetBSD/netbsd-src that referenced this pull request Oct 22, 2017

Remove superfluous space character.

12f0c68

From rjc via NetBSD/src#1

netbsd-srcmastr closed this in 8985437 Nov 23, 2017

netbsd-srcmastr pushed a commit that referenced this pull request Oct 23, 2018

Make USB port iteration code consistent, always startint at port #1

c3bbb7c

This complements change in revision 1.140

netbsd-srcmastr pushed a commit that referenced this pull request Nov 28, 2018

Fix kernel info leak.

d8c50c4

+ Possible info leak: [len=32, leaked=16] | #0 0xffffffff80baf3a7 in kleak_copyout | #1 0xffffffff80b940f8 in sys___timer_settime50 | #2 0xffffffff80259c42 in syscall

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove a superfluous <space> character before '^\'#1

remove a superfluous <space> character before '^\'#1
rjc wants to merge 1 commit into
NetBSD:trunkfrom
rjc:patch-1

rjc commented Oct 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

rjc commented Oct 18, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant