Fix variable expansion in @Header class-annotation as discussed in #262#266
Merged
Merged
Conversation
|
NetflixOSS » feign » feign-pull-requests #142 SUCCESS |
There was a problem hiding this comment.
public might not hurt, but protected is probably the right relationship. I think your first line covers why. If/when we refactor the test, we can undo this easier than undoing publicing something.
|
great job. Nit: I'd remove the question about public vs protected from the comment. in the future, just "self-note" questions in your PR "files changed" section. That way, if they are answered, you can just merge without needing to go back and scrub the commit. |
Contributor
Author
|
Noted. Thanks for merge, looking forward to new release! |
|
8.8.0 is out! |
|
oops! missed that this was marked abstract, which breaks folks. patching now |
stromnet
added a commit
to stromnet/feign
that referenced
this pull request
Sep 29, 2015
…claring class Relates to OpenFeign#266, adds support to have @Header on the parent interface too
stromnet
added a commit
to stromnet/feign
that referenced
this pull request
Sep 29, 2015
…claring class Relates to OpenFeign#266, adds support to have @Header on the parent interface too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #262.
JAXRS contract updated too.
DefaultContractTest has a new test method for this scenario.