Class-level headers from inherited class#276
Merged
Merged
Conversation
|
NetflixOSS » feign » feign-pull-requests #152 SUCCESS |
|
NetflixOSS » feign » feign-pull-requests #153 SUCCESS |
|
Looks good. mind squashing the commits? Thanks for the help on making it more intuitive. I like that you managed this w/o any new lines in src/main |
stromnet
force-pushed
the
inherited-headers
branch
from
8818c9e to
924b9de
Compare
…claring class Relates to OpenFeign#266, adds support to have @Header on the parent interface too
Contributor
Author
|
Squashed! How do you mean no new lines in src/main? There was some, although minor, changes. |
|
@stromnet only new line in src/main was an accidental newline. good tests are always welcome. |
|
NetflixOSS » feign » feign-pull-requests #154 SUCCESS |
Contributor
Author
|
Ah.. yeah, only one new line (though some changed). You're welcome! |
codefromthecrypt
pushed a commit
that referenced
this pull request
Sep 29, 2015
Class-level headers from inherited class
Contributor
Author
|
Would you mind creating a new release? Thanks! |
|
8.9.1 should be out now
|
Contributor
Author
|
Thanks, works great! |
velo
pushed a commit
that referenced
this pull request
Oct 8, 2024
Class-level headers from inherited class
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before, class annotations was only looked at if the method was declared in the parent interface. If method was declared in main interface, parent class was not looked at.
Adds more useful functionality to my prev pull req #266.