Skip to content

Add "overwrite-settings" input parameter #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxim-lobanov merged 6 commits into from
Mar 17, 2021
Merged

Add "overwrite-settings" input parameter #136

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b86b190
add overwrite-settings parameter
Mar 16, 2021
4d5942d
fix e2e tests
Mar 16, 2021
b091e76
print debug
Mar 16, 2021
242eb73
fix e2e tests
Mar 16, 2021
514dae8
add comment
Mar 16, 2021
4e1faad
remove comment
Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix e2e tests
  • Loading branch information
Maxim Lobanov committed Mar 16, 2021
commit 4d5942db5130a7ca65d76e2ff2149093e368bf56
14 changes: 9 additions & 5 deletions .github/workflows/e2e-publishing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
}

test-publishing-overwrite:
name: Validate settings.xml is not overwritten if flag is false
name: settings.xml is overwritten if flag is true
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand All @@ -63,7 +63,9 @@ jobs:
uses: actions/checkout@v2
- name: Create fake settings.xml
run: |
$xmlPath = Join-Path $HOME ".m2" "settings.xml"
$xmlDirectory = Join-Path $HOME ".m2"
$xmlPath = Join-Path $xmlDirectory "settings.xml"
New-Item -Path $xmlDirectory -ItemType Directory
Set-Content -Path $xmlPath -Value "Fake_XML"
- name: setup-java
uses: ./
Expand All @@ -86,7 +88,7 @@ jobs:
}

test-publishing-skip-overwrite:
name: Validate settings.xml is not overwritten if flag is false
name: settings.xml is not overwritten if flag is false
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand All @@ -97,7 +99,9 @@ jobs:
uses: actions/checkout@v2
- name: Create fake settings.xml
run: |
$xmlPath = Join-Path $HOME ".m2" "settings.xml"
$xmlDirectory = Join-Path $HOME ".m2"
$xmlPath = Join-Path $xmlDirectory "settings.xml"
New-Item -Path $xmlDirectory -ItemType Directory
Set-Content -Path $xmlPath -Value "Fake_XML"
- name: setup-java
uses: ./
Expand All @@ -119,7 +123,7 @@ jobs:
}

test-publishing-custom-location:
name: Validate settings.xml in custom location
name: settings.xml in custom location
runs-on: ${{ matrix.os }}
strategy:
fail-fast: false
Expand Down