Skip to content

Add "overwrite-settings" input parameter #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxim-lobanov merged 6 commits into from
Mar 17, 2021
Merged

Add "overwrite-settings" input parameter #136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b86b190
add overwrite-settings parameter
Mar 16, 2021
4d5942d
fix e2e tests
Mar 16, 2021
b091e76
print debug
Mar 16, 2021
242eb73
fix e2e tests
Mar 16, 2021
514dae8
add comment
Mar 16, 2021
4e1faad
remove comment
Mar 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
print debug
  • Loading branch information
Maxim Lobanov committed Mar 16, 2021
commit b091e7652f88fde0e3d0d583ff0856031ca72a72
4 changes: 3 additions & 1 deletion .github/workflows/e2e-publishing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ jobs:
Get-Content $xmlPath | ForEach-Object { Write-Host $_ }

$xml = Get-Content $xmlPath -Raw
if ($raw -notlike 'maven') {
if ($raw -notlike '*maven*') {
throw "settings.xml file is not overwritten"
}

Expand Down Expand Up @@ -118,6 +118,8 @@ jobs:
run: |
$xmlPath = Join-Path $HOME ".m2" "settings.xml"
$content = Get-Content -Path $xmlPath -Raw
Write-Host $content

if ($content -ne "Fake_XML") {
throw "settings.xml file was overwritten but it should not be"
}
Expand Down
2 changes: 1 addition & 1 deletion dist/setup/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13341,7 +13341,7 @@ function write(directory, settings, overwriteSettings) {
core.info(`Writing to ${location}`);
}
else {
core.info(`Skipping generation '${location}' - it already exists and overwriting is not required`);
core.info(`Skipping generation ${location} because file already exists and overwriting is not required`);
return;
}
return fs.writeFileSync(location, settings, {
Expand Down
2 changes: 1 addition & 1 deletion src/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ async function write(directory: string, settings: string, overwriteSettings: boo
core.info(`Writing to ${location}`);
} else {
core.info(
`Skipping generation '${location}' - it already exists and overwriting is not required`
`Skipping generation ${location} because file already exists and overwriting is not required`
);
return;
}
Expand Down