chore(deps): bump vite from 5.3.5 to 5.4.17#1
Closed
dependabot[bot] wants to merge 1 commit into
Closed
Conversation
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 5.3.5 to 5.4.17. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v5.4.17/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v5.4.17/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-version: 5.4.17 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Author
|
Superseded by #2. |
digital-codes
pushed a commit
that referenced
this pull request
May 7, 2026
#1 — `gl.deleteTexture` orphaned normal-map textures on `reset()`. The map was cleared but the underlying `WebGLTexture` objects leaked (they're not GC'd until explicit delete or context loss). #2 — Drop hardcoded `precision highp float;` from the lit fragment shader. `GLShader.setPrecision()` already auto-injects the highest precision the device's fragment stage supports via `getMaxShaderPrecision()`. Hardcoding `highp` would refuse to compile on older mobile GPUs that only support `mediump`. #3 — `MAX_LIGHTS` was duplicated as a literal `8` in `stage.ts` and exported from `multitexture.js`. Single source of truth — import from the shader file. #4 — `Stage.collectLightingUniforms` derived the shader `radius` from `Math.max(light.radiusX, light.radiusY)`, which ignores transforms. A scaled light's brightness range now tracks its visible range (matches what the cutout pass already does via `getVisibleArea()`). New regression test covers the scale-2 case. #5 — Widen JSDoc types for `normalMap` to match runtime acceptance (`OffscreenCanvas`, `ImageBitmap`, `HTMLVideoElement` all flow through fine — the setter validates duck-typed `{ width, height }`). Updated on `Sprite`, `TextureAtlas`, and `QuadBatcher`'s `normalMapTextures` / `boundNormalMaps` types + the `_uploadOrBindNormalMap` parameter doc. #6 — `_uploadOrBindNormalMap` mirrored only the `gl.texImage2D(...image)` fast path; `OffscreenCanvas` instances weren't handled. Added the same `transferToImageBitmap()` branch `MaterialBatcher.createTexture2D` uses, so atlas-paired OffscreenCanvas normal maps work too. #7 — `boundNormalMaps[unit]` could go stale after `cache.resetUnitAssignments()` (which drops color-slot bindings when units are exhausted). The next normal-mapped quad at a reused slot might falsely skip a rebind. Defensively `.fill(null)` after the cache reset so the next `addQuad` re-uploads cleanly. #8 — `setLightUniforms` was called right after `beginPostEffect` — before `setProjection()` (which can flush the pending batch). Moved to *after* the projection setup + container.translate, just before `container.preDraw()`, so the uniforms are guaranteed to apply to every lit quad pushed by the upcoming world tree walk. #9 — Document the `maxBatchTextures` halving trade-off. The halving is necessary for the paired (color, normal) layout to fit WebGL1's 8-unit minimum spec; conditional halving would require runtime introspection that's out of scope. Comment now explains the rationale + bounds for future tuners. Test additions: 1 new case (radius reflects scaled bounds). The other fixes are either WebGL-state-only (#1, #6, #7), pure docs (#5, #9), or refactors that the existing test surface already covers. Total impact: 84 / 84 test files, 2841 / 2841 tests still pass; full lint chain clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps vite from 5.3.5 to 5.4.17.
Release notes
Sourced from vite's releases.
... (truncated)
Changelog
Sourced from vite's changelog.
... (truncated)
Commits
0a2518arelease: v5.4.1784b2b46fix: backport #19782, fs check with svg and relative paths (#19784)712cb71release: v5.4.16b627c50fix: backport #19761, fs check in transform middleware (#19762)9b0f4c8release: v5.4.15807d7f0fix: backport #19702, fs raw query with query separators (#19703)e7eb3c5release: v5.4.147d1699cfix: allow CORS from loopback addresses by default (#19249)9df6e6bfix:preview.allowedHostswith specific values was not respected (#19246)a1824c5release: v5.4.13Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.