Skip to content

feat: add filter in elasticsearch backend#375

Merged
alaeddine-13 merged 21 commits into
mainfrom
feat-id-filter
Jun 10, 2022
Merged

feat: add filter in elasticsearch backend#375
alaeddine-13 merged 21 commits into
mainfrom
feat-id-filter

Conversation

@jemmyshin

@jemmyshin jemmyshin commented May 30, 2022 •
edited by alaeddine-13
Loading

Copy link
Copy Markdown
Contributor

closes: #374

@jemmyshin jemmyshin requested review from alaeddine-13 and numb3r3 May 30, 2022 04:40
@jemmyshin jemmyshin requested a review from davidbp May 30, 2022 04:40
numb3r3
numb3r3 suggested changes May 30, 2022
View reviewed changes
Comment thread docarray/array/storage/elastic/find.py Outdated
Comment thread docarray/array/storage/elastic/find.py Outdated
Comment thread docarray/array/storage/elastic/find.py Outdated
Comment thread docarray/array/storage/elastic/find.py Outdated
@numb3r3

numb3r3 commented May 30, 2022

Copy link
Copy Markdown
Contributor

and add unittest

@codecov

codecov Bot commented May 30, 2022 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #375 (cd42289) into main (6881351) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #375      +/-   ##
==========================================
+ Coverage   86.47%   86.51%   +0.03%     
==========================================
  Files         134      134              
  Lines        6367     6385      +18     
==========================================
+ Hits         5506     5524      +18     
  Misses        861      861
Flag Coverage Δ
docarray 86.51% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
docarray/__init__.py 75.00% <100.00%> (ø)
docarray/array/mixins/find.py 87.35% <100.00%> (ø)
docarray/array/storage/annlite/backend.py 95.71% <100.00%> (+0.12%) ⬆️
docarray/array/storage/base/backend.py 85.18% <100.00%> (+2.57%) ⬆️
docarray/array/storage/elastic/backend.py 94.59% <100.00%> (+0.20%) ⬆️
docarray/array/storage/elastic/find.py 91.22% <100.00%> (+1.64%) ⬆️
docarray/array/storage/elastic/getsetdel.py 100.00% <100.00%> (ø)
docarray/array/storage/qdrant/backend.py 95.87% <100.00%> (-0.05%) ⬇️
docarray/array/storage/weaviate/backend.py 87.50% <100.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d88340f...cd42289. Read the comment docs.

@github-actions github-actions Bot added size/s and removed size/m labels May 31, 2022
@numb3r3

numb3r3 commented May 31, 2022

Copy link
Copy Markdown
Contributor

@jemmyshin don't use merge, please use the following command to rebase your PR:

git pull --rebase origin main

numb3r3
numb3r3 suggested changes May 31, 2022
View reviewed changes
Comment thread docarray/array/mixins/find.py Outdated
Comment thread docarray/array/mixins/find.py Outdated
Comment thread docarray/array/mixins/find.py Outdated
Comment thread docarray/array/storage/elastic/find.py Outdated
numb3r3
numb3r3 suggested changes Jun 1, 2022
View reviewed changes
Comment thread docarray/array/storage/elastic/find.py Outdated
Comment thread docarray/array/storage/elastic/find.py Outdated
@jemmyshin jemmyshin marked this pull request as draft June 1, 2022 03:30
numb3r3
numb3r3 suggested changes Jun 8, 2022
View reviewed changes
Comment thread tests/unit/array/mixins/test_find.py Outdated
Comment thread tests/unit/array/mixins/test_find.py Outdated
@jemmyshin jemmyshin requested a review from numb3r3 June 8, 2022 05:56
@numb3r3

numb3r3 commented Jun 8, 2022

Copy link
Copy Markdown
Contributor

@jemmyshin please fix the issue related with code formating

numb3r3
numb3r3 approved these changes Jun 9, 2022
View reviewed changes

@numb3r3 numb3r3 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions Bot added size/m and removed size/s labels Jun 9, 2022
@github-actions

github-actions Bot commented Jun 10, 2022

Copy link
Copy Markdown

📝 Docs are deployed on https://ft-feat-id-filter--jina-docs.netlify.app 🎉

davidbp
davidbp approved these changes Jun 10, 2022
View reviewed changes

@davidbp davidbp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alaeddine-13 alaeddine-13 merged commit 1482421 into main Jun 10, 2022
@alaeddine-13 alaeddine-13 deleted the feat-id-filter branch June 10, 2022 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alaeddine-13 alaeddine-13 alaeddine-13 left review comments

@JoanFM JoanFM JoanFM approved these changes

+2 more reviewers

@davidbp davidbp davidbp approved these changes

@numb3r3 numb3r3 numb3r3 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/core area/docs area/setup area/testing component/array size/m

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add filtering and pre-filtering to ElasticSearch storage backend

5 participants

@jemmyshin @numb3r3 @alaeddine-13 @davidbp @JoanFM