Skip to content

feat: add filter in elasticsearch backend #375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alaeddine-13 merged 21 commits into from
Jun 10, 2022
Merged

feat: add filter in elasticsearch backend #375

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
fa9b69f
feat: elastic query
numb3r3 May 31, 2022
6f0f9c9
fix: change return type
numb3r3 Jun 1, 2022
609a027
test: add test for filter
jemmyshin Jun 8, 2022
fbdeb55
test: add test for filter
jemmyshin Jun 8, 2022
52868ba
test: add limit test
jemmyshin Jun 8, 2022
ddaaef1
fix: fix format
jemmyshin Jun 9, 2022
8052531
refactor: create normalize columns method
alaeddine-13 Jun 9, 2022
1d0d25d
feat: add columns to elasticsearch
alaeddine-13 Jun 9, 2022
49bd85a
Merge branch 'main' into feat-id-filter
alaeddine-13 Jun 9, 2022
9df1c93
test: cover elasticsearch filtering
alaeddine-13 Jun 9, 2022
89ca189
test: assert result len
alaeddine-13 Jun 9, 2022
c339b59
docs: document elasticsearch filtering
alaeddine-13 Jun 9, 2022
67950f9
fix: merge conflict
alaeddine-13 Jun 9, 2022
a4fd02c
feat: enable pre-filtering for elasticsearch backend
alaeddine-13 Jun 9, 2022
00b003c
test: cover pre-filtering for elasticsearch
alaeddine-13 Jun 10, 2022
b84da9c
fix: proper column normalization for annlite
alaeddine-13 Jun 10, 2022
c252409
chore: upgrade elasticsearch client and image
alaeddine-13 Jun 10, 2022
d6f8ab4
docs: document pre-filtering for elasticsearch
alaeddine-13 Jun 10, 2022
09b80d7
docs: fix distance metric
alaeddine-13 Jun 10, 2022
33331b9
test: pre-filtering no more unsupported in elasticsearch
alaeddine-13 Jun 10, 2022
cd42289
test: set random seed
alaeddine-13 Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: pre-filtering no more unsupported in elasticsearch
  • Loading branch information
@alaeddine-13
alaeddine-13 committed Jun 10, 2022
commit 33331b94e83287eabfba6dddd9b8012c087cc373
2 changes: 1 addition & 1 deletion tests/unit/array/mixins/test_find.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,7 +436,7 @@ def test_weaviate_filter_query(start_storage):
assert isinstance(da._filter(filter={}), type(da))


@pytest.mark.parametrize('storage', ['memory', 'elasticsearch'])
@pytest.mark.parametrize('storage', ['memory'])
def test_unsupported_pre_filtering(storage, start_storage):

n_dim = 128
Expand Down