Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
kevjumba committed Jul 8, 2022
commit c17f6fc75f56f8b95955c1fd97633b20a3f2a52b
1 change: 1 addition & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,7 @@ install-feast-ci-locally:
pip install -e ".[ci]"

# Needs feast package to setup the feature store
# CGO flag is due to this issue: https://github.com/golang/go/wiki/InvalidFlag
test-go: compile-protos-go compile-go-lib install-feast-ci-locally
CGO_LDFLAGS_ALLOW=".*" go test -tags cgo,ccalloc ./...

Expand Down
4 changes: 2 additions & 2 deletions go/internal/feast/onlinestore/sqliteonlinestore_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@ func TestSqliteOnlineRead(t *testing.T) {
dir := t.TempDir()
feature_repo_path := filepath.Join(dir, "feature_repo")
test.SetupCleanFeatureRepo(dir)

config, err := registry.NewRepoConfigFromFile(feature_repo_path)
assert.Nil(t, err)

store, err := NewSqliteOnlineStore("feature_repo", config, config.OnlineStore)
defer store.Destruct()
assert.Nil(t, err)
Expand All @@ -51,7 +51,7 @@ func TestSqliteOnlineRead(t *testing.T) {
JoinKeys: []string{"driver_id"},
EntityValues: []*types.Value{{Val: &types.Value_Int64Val{Int64Val: 1001}}},
}
entity_key3 := types.EntityKey{
entity_key3 := types.EntityKey{
JoinKeys: []string{"driver_id"},
EntityValues: []*types.Value{{Val: &types.Value_Int64Val{Int64Val: 1003}}},
}
Expand Down
2 changes: 0 additions & 2 deletions go/internal/test/go_integration_test_utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,14 +89,12 @@ func GetLatestFeatures(Rows []*Row, entities map[int64]bool) map[int64]*Row {

func SetupCleanFeatureRepo(basePath string) error {
cmd := exec.Command("feast", "init", "feature_repo")

path, err := filepath.Abs(basePath)
cmd.Env = os.Environ()

if err != nil {
return err
}

cmd.Dir = path
err = cmd.Run()
if err != nil {
Expand Down