Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix
Signed-off-by: Kevin Zhang <kzhang@tecton.ai>
  • Loading branch information
kevjumba committed Jul 7, 2022
commit f3901d3617dff4c1ca513db1db16e8a13d5be913
1 change: 0 additions & 1 deletion go/embedded/online_features.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,6 @@ func (s *OnlineFeatureService) GetOnlineFeatures(
outputFields := make([]arrow.Field, 0)
outputColumns := make([]arrow.Array, 0)
pool := memory.NewCgoArrowAllocator()
// pool := memory.NewGoAllocator()
for _, featureVector := range resp {
outputFields = append(outputFields,
arrow.Field{
Expand Down
27 changes: 7 additions & 20 deletions sdk/python/tests/integration/online_store/test_universal_online.py
Original file line number Diff line number Diff line change
Expand Up @@ -448,8 +448,6 @@ def test_online_retrieval_with_event_timestamps(
def test_online_retrieval(
environment, universal_data_sources, feature_server_endpoint, full_feature_names
):
import faulthandler; faulthandler.enable()

fs = environment.feature_store
entities, datasets, data_sources = universal_data_sources
feature_views = construct_universal_feature_views(data_sources)
Expand Down Expand Up @@ -551,24 +549,13 @@ def test_online_retrieval(
unprefixed_feature_refs.remove("conv_rate_plus_100")
unprefixed_feature_refs.remove("conv_rate_plus_val_to_add")

# online_features_dict = get_online_features_dict(
# environment=environment,
# endpoint=feature_server_endpoint,
# features=feature_refs,
# entity_rows=entity_rows,
# full_feature_names=full_feature_names,
# )
import psutil

for i in range(1000):
print(psutil.virtual_memory())
online_features_dict = get_online_features_dict(
environment=environment,
endpoint=feature_server_endpoint,
features=feature_refs,
entity_rows=entity_rows,
full_feature_names=full_feature_names,
)
online_features_dict = get_online_features_dict(
environment=environment,
endpoint=feature_server_endpoint,
features=feature_refs,
entity_rows=entity_rows,
full_feature_names=full_feature_names,
)

# Test that the on demand feature views compute properly even if the dependent conv_rate
# feature isn't requested.
Expand Down