Skip to content

feat: Feast AWS Athena offline store (again) #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 11 commits into from
Aug 10, 2022
Merged

feat: Feast AWS Athena offline store (again) #3044

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
693e9df
fixed bugs, cleaned code, added AthenaDataSourceCreator
Jul 24, 2022
7cbd232
fixed bugs, cleaned code, added some methods. test_universal_historic…
Jul 31, 2022
9011036
fixed bugs to pass test_validation
Aug 7, 2022
23905a1
changed boolean data type mapping
Aug 8, 2022
5fc9e6e
1.added test-python-universal-athena in Makefile 2.replaced database…
Aug 8, 2022
e8db748
format,run lint
Aug 9, 2022
228555c
revert merge changes
adchia Aug 9, 2022
e9b6180
add entity_key_serialization
adchia Aug 9, 2022
c7e59a3
restore deleted file
adchia Aug 9, 2022
327289e
modified confusing environment variable names, added how to use Athena
younggyu-oh Aug 9, 2022
ce1710c
enforce AthenaSource to have a name
younggyu-oh Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
enforce AthenaSource to have a name 
Signed-off-by: Youngkyu OH <toping4445@gmail.com>
  • Loading branch information
@younggyu-oh
younggyu-oh committed Aug 10, 2022
commit ce1710c9f08d9fb69a0380e329f6aa1ae92dacdd
23 changes: 8 additions & 15 deletions sdk/python/feast/infra/offline_stores/contrib/athena_offline_store/athena_source.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
import warnings
from typing import Callable, Dict, Iterable, Optional, Tuple

from feast import type_map
from feast.data_source import DataSource
from feast.errors import DataSourceNotFoundException
from feast.errors import DataSourceNoNameException, DataSourceNotFoundException
from feast.feature_logging import LoggingDestination
from feast.protos.feast.core.DataSource_pb2 import DataSource as DataSourceProto
from feast.protos.feast.core.FeatureService_pb2 import (
Expand Down Expand Up @@ -56,26 +55,20 @@ def __init__(


"""
# The default Athena schema is named "public".

_database = "default" if table and not database else database
self.athena_options = AthenaOptions(
table=table, query=query, database=_database, data_source=data_source
)

if table is None and query is None:
raise ValueError('No "table" argument provided.')
_name = name
if not _name:
if table:
_name = table
else:
warnings.warn(
(
f"Starting in Feast 0.21, Feast will require either a name for a data source (if using query) "
f"or `table`: {self.query}"
),
DeprecationWarning,
)

# If no name, use the table as the default name.
if name is None and table is None:
raise DataSourceNoNameException()
_name = name or table
assert _name

super().__init__(
name=_name if _name else "",
Expand Down