Skip to content

feat: Feast AWS Athena offline store (again) #3044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
feast-ci-bot merged 11 commits into from
Aug 10, 2022
Merged

feat: Feast AWS Athena offline store (again) #3044

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
693e9df
fixed bugs, cleaned code, added AthenaDataSourceCreator
Jul 24, 2022
7cbd232
fixed bugs, cleaned code, added some methods. test_universal_historic…
Jul 31, 2022
9011036
fixed bugs to pass test_validation
Aug 7, 2022
23905a1
changed boolean data type mapping
Aug 8, 2022
5fc9e6e
1.added test-python-universal-athena in Makefile 2.replaced database…
Aug 8, 2022
e8db748
format,run lint
Aug 9, 2022
228555c
revert merge changes
adchia Aug 9, 2022
e9b6180
add entity_key_serialization
adchia Aug 9, 2022
c7e59a3
restore deleted file
adchia Aug 9, 2022
327289e
modified confusing environment variable names, added how to use Athena
younggyu-oh Aug 9, 2022
ce1710c
enforce AthenaSource to have a name
younggyu-oh Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add entity_key_serialization 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia @younggyu-oh
adchia authored and younggyu-oh committed Aug 9, 2022
commit e9b6180e229964282f719874aabda2af1340473d
3 changes: 2 additions & 1 deletion sdk/python/feast/templates/athena/feature_store.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ offline_store:
region: ap-northeast-2
database: sampledb
data_source: AwsDataCatalog
s3_staging_location: s3://sagemaker-yelo-test
s3_staging_location: s3://sagemaker-yelo-test
entity_key_serialization_version: 2