Skip to content

fix: Fix incorrect on demand feature view diffing and improve Java tests #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 8 commits into from
Aug 11, 2022
Merged

fix: Fix incorrect on demand feature view diffing and improve Java tests #3074

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a02b997
fix: Fix ODFV bug
adchia Aug 11, 2022
4f93f6f
fix: Fix ODFV bug 2
adchia Aug 11, 2022
55ee9f0
add python test
adchia Aug 11, 2022
1dfbfd3
rename
adchia Aug 11, 2022
3847ff5
remove accidental test
adchia Aug 11, 2022
f12bdb5
add comment in setup_it
adchia Aug 11, 2022
73394ed
fix workflow
adchia Aug 11, 2022
2412c01
lint
adchia Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia
adchia committed Aug 11, 2022
commit 1dfbfd392d9f3b9529ad236cc81e1ca6391b3625
2 changes: 1 addition & 1 deletion .github/workflows/java_pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ jobs:
sudo apt install -y -V ./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
sudo apt update
sudo apt install -y -V libarrow-dev
- name: Install dependencies
- name: Install Python dependencies
run: make install-python-ci-dependencies
- name: Run integration tests
run: make test-java-integration
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pr_integration_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ jobs:
- name: Install apache-arrow on macos
if: matrix.os == 'macOS-latest'
run: brew install apache-arrow
- name: Install Python dependencies
- name: Install dependencies
run: make install-python-ci-dependencies
- name: Setup Redis Cluster
run: |
Expand Down