Skip to content

fix: Fix incorrect on demand feature view diffing and improve Java tests #3074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adchia merged 8 commits into from
Aug 11, 2022
Merged

fix: Fix incorrect on demand feature view diffing and improve Java tests #3074

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
a02b997
fix: Fix ODFV bug
adchia Aug 11, 2022
4f93f6f
fix: Fix ODFV bug 2
adchia Aug 11, 2022
55ee9f0
add python test
adchia Aug 11, 2022
1dfbfd3
rename
adchia Aug 11, 2022
3847ff5
remove accidental test
adchia Aug 11, 2022
f12bdb5
add comment in setup_it
adchia Aug 11, 2022
73394ed
fix workflow
adchia Aug 11, 2022
2412c01
lint
adchia Aug 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove accidental test 
Signed-off-by: Danny Chiao <danny@tecton.ai>
  • Loading branch information
@adchia
adchia committed Aug 11, 2022
commit 3847ff5b55a0479a8af52c1d0aed114aabcc44f8
53 changes: 0 additions & 53 deletions sdk/python/tests/unit/local_feast_tests/test_local_feature_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,59 +97,6 @@ def test_apply_feature_view_success(test_feature_store):
test_feature_store.teardown()


@pytest.mark.parametrize(
"test_feature_store",
[lazy_fixture("feature_store_with_local_registry")],
)
def test_apply_on_demand_feature_view_success(test_feature_store):
# Create Feature Views
batch_source = FileSource(
file_format=ParquetFormat(),
path="file://feast/*",
timestamp_field="ts_col",
created_timestamp_column="timestamp",
)

entity = Entity(name="fs1_my_entity_1", join_keys=["entity_id"])

fv1 = FeatureView(
name="my_feature_view_1",
schema=[
Field(name="fs1_my_feature_1", dtype=Int64),
Field(name="fs1_my_feature_2", dtype=String),
Field(name="fs1_my_feature_3", dtype=Array(String)),
Field(name="fs1_my_feature_4", dtype=Array(Bytes)),
Field(name="entity_id", dtype=Int64),
],
entities=[entity],
tags={"team": "matchmaking"},
source=batch_source,
ttl=timedelta(minutes=5),
)

# Register Feature View
test_feature_store.apply([entity, fv1])

feature_views = test_feature_store.list_feature_views()

# List Feature Views
assert (
len(feature_views) == 1
and feature_views[0].name == "my_feature_view_1"
and feature_views[0].features[0].name == "fs1_my_feature_1"
and feature_views[0].features[0].dtype == Int64
and feature_views[0].features[1].name == "fs1_my_feature_2"
and feature_views[0].features[1].dtype == String
and feature_views[0].features[2].name == "fs1_my_feature_3"
and feature_views[0].features[2].dtype == Array(String)
and feature_views[0].features[3].name == "fs1_my_feature_4"
and feature_views[0].features[3].dtype == Array(Bytes)
and feature_views[0].entities[0] == "fs1_my_entity_1"
)

test_feature_store.teardown()


@pytest.mark.parametrize(
"test_feature_store",
[lazy_fixture("feature_store_with_local_registry")],
Expand Down