fix(page): clean up glass/sidebar-main vars#8274
Merged
Merged
Conversation
Contributor
WalkthroughMoved Page sidebar/main visual and layout rules to new CSS variables on the page root, refactored glass-theme overrides to set glass-specific variables (including xl breakpoint adjustments), removed prior inlined glass rules, and changed a global sidebar overflow selector to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Collaborator
|
Preview: https://pf-pr-8274.surge.sh A11y report: https://pf-pr-8274-a11y.surge.sh |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/patternfly/components/Page/page.scss`:
- Around line 253-278: The xl breakpoint margin overrides for sidebar-main (the
`@media` (min-width: $pf-v6-global--breakpoint--xl) block setting
--#{$page}__sidebar-main--MarginBlockStart / MarginBlockEnd / MarginInlineStart
/ MarginInlineEnd) are currently global and should only apply to the glass
theme; move this entire `@media` block inside the :where(.pf-v6-theme-glass) & {
... } scope (or alternatively change those four vars to their --glass variants)
so non-glass themes do not inherit the page-chrome inset margins.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro
Run ID: a343b303-d32a-42a0-9d49-d5f3ffe4da73
📒 Files selected for processing (2)
src/patternfly/components/Page/page.scsssrc/patternfly/patternfly.scss
Collaborator
|
🎉 This PR is included in version 6.5.0-prerelease.65 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Apr 10, 2026
This was referenced May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #8273
fixes #8243
Creates proper variables for a bunch of glass styles, mostly around the sidebar/sidebar-main styles. If done properly, this PR should not introduce any changes. I ran visual regressions and looks like it produced no errors but did fix a collapsed sidebar issue as noted in #8243
Here is the backstop report: BackstopJS Report.pdf
FWIW
.pf-v6-c-page__sidebar-mainis a new element and is not required unless you're using glass theme.Summary by CodeRabbit
Style
Refactor