Swith to Master/Detail Publications#242
Merged
Merged
Conversation
daviddavis
approved these changes
Apr 26, 2019
daviddavis
left a comment
daviddavis
left a comment
Contributor
There was a problem hiding this comment.
LGTM. one thing you might want to do is update the docs.
RequiredPR: pulp/pulpcore-plugin#93 RequiredPR: pulp/pulpcore#103 https://pulp.plan.io/issues/4699 fixes #4699
This is included in the Publications PR because the docs needed to be updated, and the preceeding docs (sync) didn't work together in copy/paste mode. I wrote these scripts to test the Publications PR, and decided to use them in the docs. [noissue]
asmacdo
force-pushed
the
master-detail-publications
branch
from
ee5370e to
4c72c63
Compare
asmacdo
commented
Apr 29, 2019
| wait_for_pulp() { | ||
| unset CREATED_RESOURCE | ||
| local task_url=$1 | ||
| while [ -z "$CREATED_RESOURCE" ] |
Contributor
Author
There was a problem hiding this comment.
This seems to fail sometimes, CREATED_RESOURCE gets set to null.
asmacdo
commented
Apr 29, 2019
| @@ -0,0 +1,19 @@ | |||
| # This script will execute the component scripts and ensure that the documented examples | |||
| # work as expected. | |||
Contributor
Author
There was a problem hiding this comment.
Idea for another day:
It might be worth running quickstart.sh when building the docs, to test it out. As a possible side benefit, we will populate the db, which might allow us to include examples in the REST API docs.
asmacdo
force-pushed
the
master-detail-publications
branch
2 times, most recently
from
4be546b to
a6fdfc5
Compare
Remove Publishers and move Publish tests into Publication Create. Then write minimal publication crud tests.
asmacdo
force-pushed
the
master-detail-publications
branch
from
a6fdfc5 to
4a25515
Compare
dkliban
approved these changes
Apr 29, 2019
CodeHeeler
approved these changes
Apr 29, 2019
CodeHeeler
left a comment
CodeHeeler
left a comment
Contributor
There was a problem hiding this comment.
LGTM
with the caveat that you open issues to a) improve the tests and b) take care of the other TODOs here so they won't get forgotten.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://pulp.plan.io/issues/4699
fixes #4699