bpo-33061: Add missing 'NoReturn' to __all__ in typing.py#6127
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Thank you! Just one small comment.
| @@ -0,0 +1 @@ | |||
| Add missing 'NoReturn' to __all__ in typing.py | |||
There was a problem hiding this comment.
I think both NoReturn and __all__ should be in double backticks, like this ``__all__``.
|
I'm not sure why my CLA isn't found. Here's a copy: |
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Have you added your GitHub account name in your account on bugs.python.org?
| @@ -0,0 +1 @@ | |||
| Add missing ``'NoReturn'`` to ``__all__`` in typing.py | |||
There was a problem hiding this comment.
The inner single quotes '...' around NoReturn are not needed and can be removed.
|
Yes, https://bugs.python.org/user28094 shows my GitHub username as |
|
It looks like your form was not yet processed, it doesn't appear on your b.p.o. page. I will merge this now, since it is a minor contribution and I have seen your signed form. Could you please also make a similar PR to the typing repo that contains the backports to older Python 3 versions and to Python 2? |
5 participants
https://bugs.python.org/issue33061