[3.7] bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127)#6162
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
|
@aetracht So what is the situation with your CLA? It looks like it is still not found. |
|
I really have no idea: I went to an incognito browser and opened my profile. After logging in, I see the expected GitHub username (aetracht) and email (allen@duolingo.com). I guess I'll try creating a new CLA and see if that helps. |
|
Here's the new (second attempt) CLA: |
|
@aetracht Are you sure you have followed all CLA instructions? (I don't know how it is done now. Also this is not a request to action, just a question, please re-read the CLA instructions and check if you followed all steps.) |
|
Following the steps in: https://devguide.python.org/pullrequest/#licensing
At this point I'm quite at a loss. I'll try one more time, all in an incognito window and see if that helps. |
|
I have created a new account, with both the login name and GitHub name the same, I don't know if this will just further confuse things or maybe fix them. In either case, I don't think I can do any more to fix this without support from python.org. |
|
There is a manual review step involved, which usually takes a few business
days? (Maybe typically 1?)
|
|
@ilevkivskyi: Please replace |
|
OK, CLA is still red, but since this is just one line backport (and beta 3 is in 3 days) I am merging this. But please, sort it out before your next PR. Thanks! |
Since it is a bugfix, I think this should be backported to 3.7.
https://bugs.python.org/issue33061