Skip to content

[3.7] bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127)#6162

Merged
ilevkivskyi merged 1 commit into
python:3.7from
ilevkivskyi:backport-noreturn-all
Mar 23, 2018
Merged

[3.7] bpo-33061: Add missing 'NoReturn' to __all__ in typing.py (GH-6127)#6162
ilevkivskyi merged 1 commit into
python:3.7from
ilevkivskyi:backport-noreturn-all

Conversation

@ilevkivskyi

@ilevkivskyi ilevkivskyi commented Mar 20, 2018

Copy link
Copy Markdown
Member

Since it is a bugfix, I think this should be backported to 3.7.

https://bugs.python.org/issue33061

@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@ilevkivskyi

Copy link
Copy Markdown
Member Author

@aetracht So what is the situation with your CLA? It looks like it is still not found.

@aetracht

Copy link
Copy Markdown
Contributor

I really have no idea: I went to an incognito browser and opened my profile. After logging in, I see the expected GitHub username (aetracht) and email (allen@duolingo.com). I guess I'll try creating a new CLA and see if that helps.

@aetracht

aetracht commented Mar 20, 2018

Copy link
Copy Markdown
Contributor

Here's the new (second attempt) CLA:
Uploading Python Contributor Agreement Form - signed (1).pdf…
I'll check back in a day and see if it takes.

@ilevkivskyi

Copy link
Copy Markdown
Member Author

@aetracht Are you sure you have followed all CLA instructions? (I don't know how it is done now. Also this is not a request to action, just a question, please re-read the CLA instructions and check if you followed all steps.)

@aetracht

Copy link
Copy Markdown
Contributor

Following the steps in: https://devguide.python.org/pullrequest/#licensing

  1. Register for an account on BPO: https://bugs.python.org/user28094 exists with my name, login name, GitHub Name, and email address.
    1. Curiously, the system seems to have a problem with my email address: sometimes it shows my personal email (aetracht@gmail.com), and sometimes my work email (allen@duolingo.com). I don't know if something is wrong there.
  2. Make suer my GitHub username is listed in the "Your Details" section at bpo: It says aetracht which matches my profile at https://github.com/aetracht.
  3. Fill out and sign the PSF contributor form.
    Python Contributor Agreement Form - signed (2).pdf
    1. The username from the CLA is AllenTracht which matches my bpo login name AllenTracht
    2. The only thing that looks at all curious is the email.

At this point I'm quite at a loss. I'll try one more time, all in an incognito window and see if that helps.

@aetracht

Copy link
Copy Markdown
Contributor

I have created a new account, with both the login name and GitHub name the same, aetracht, and executed the CLA once again. https://bugs.python.org/user28156
Python Contributor Agreement Form - signed (3).pdf

I don't know if this will just further confuse things or maybe fix them. In either case, I don't think I can do any more to fix this without support from python.org.

@gvanrossum

gvanrossum commented Mar 22, 2018 via email

Copy link
Copy Markdown
Member

@bedevere-bot

Copy link
Copy Markdown

@ilevkivskyi: Please replace # with GH- in the commit message next time. Thanks!

@ilevkivskyi

Copy link
Copy Markdown
Member Author

OK, CLA is still red, but since this is just one line backport (and beta 3 is in 3 days) I am merging this. But please, sort it out before your next PR. Thanks!

@ilevkivskyi ilevkivskyi deleted the backport-noreturn-all branch March 23, 2018 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants