bpo-34040, multiprocessing: Fix test_forkserver_sigkill()#8081
Merged
Conversation
Fix test_forkserver_sigkill() of test_multiprocessing_forkserver: give more time to the first child process to complete, double of its sleep. Reduce also the sleep from 1000 ms to 500 ms, to not change the total duration of the test.
Contributor
|
Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7. |
|
GH-8084 is a backport of this pull request to the 3.7 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 4, 2018
) Fix test_forkserver_sigkill() of test_multiprocessing_forkserver: give more time to the first child process to complete, double the sleep in the parent process. Reduce also the child process sleep from 1000 ms to 500 ms, to not change the total duration of the test. (cherry picked from commit 07888e1) Co-authored-by: Victor Stinner <vstinner@redhat.com>
|
GH-8085 is a backport of this pull request to the 3.6 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 4, 2018
) Fix test_forkserver_sigkill() of test_multiprocessing_forkserver: give more time to the first child process to complete, double the sleep in the parent process. Reduce also the child process sleep from 1000 ms to 500 ms, to not change the total duration of the test. (cherry picked from commit 07888e1) Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington
added a commit
that referenced
this pull request
Jul 4, 2018
Fix test_forkserver_sigkill() of test_multiprocessing_forkserver: give more time to the first child process to complete, double the sleep in the parent process. Reduce also the child process sleep from 1000 ms to 500 ms, to not change the total duration of the test. (cherry picked from commit 07888e1) Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington
added a commit
that referenced
this pull request
Jul 4, 2018
Fix test_forkserver_sigkill() of test_multiprocessing_forkserver: give more time to the first child process to complete, double the sleep in the parent process. Reduce also the child process sleep from 1000 ms to 500 ms, to not change the total duration of the test. (cherry picked from commit 07888e1) Co-authored-by: Victor Stinner <vstinner@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test_forkserver_sigkill() of test_multiprocessing_forkserver:
give more time to the first child process to complete, double of its
sleep.
Reduce also the sleep from 1000 ms to 500 ms, to not change the total
duration of the test.
https://bugs.python.org/issue34040