bpo-32842: Fixing epoll timeout logics#5670
Closed
YoSTEALTH wants to merge 1215 commits into
Closed
Conversation
…GH-4304) (#4321) * fix doc for multiprocessing.connection.Client The authenticate argument does not exist on either Client or Listener: - https://github.com/python/cpython/blob/master/Lib/multiprocessing/connection.pyGH-L483 (master) - https://github.com/python/cpython/blob/3.6/Lib/multiprocessing/connection.pyGH-L478 (3.6) - https://github.com/python/cpython/blob/3.5/Lib/multiprocessing/connection.pyGH-L478 (3.5) - https://github.com/python/cpython/blob/3.4/Lib/multiprocessing/connection.pyGH-L487 (3.4) The documentation also claimed that these functions will call `current_process().auth_key`, for which I could find no evidence in the code. I rewrote the documentation to reflect the actual behavior. Also made some small changes to vary sentence structure. (cherry picked from commit 1e5d54c)
(cherry picked from commit 01ae58d)
It can be removed after python/peps@c28890f (cherry picked from commit 7c9da3e)
(cherry picked from commit e197a85)
…Back_Print()). (GH-4289) (#4406) * Setting sys.tracebacklimit to 0 or less now suppresses printing tracebacks. * Setting sys.tracebacklimit to None now causes using the default limit. * Setting sys.tracebacklimit to an integer larger than LONG_MAX now means using the limit LONG_MAX rather than the default limit. * Fixed integer overflows in the case of more than 2**31 traceback items on Windows. * Fixed output errors handling.. (cherry picked from commit edad8ee)
(cherry picked from commit 28607e0)
(cherry picked from commit 6ea20fc)
…t. (GH-5639) GUI test test_file_buttons() only looks at initial ascii-only lines, but failed on systems where open() defaults to 'ascii' because readline() internally reads and decodes far enough ahead to encounter a non-ascii character in CREDITS.txt. (cherry picked from commit f34e03e) Co-authored-by: Terry Jan Reedy <tjreedy@udel.edu>
# current
if timeout is None:
timeout = -1
elif timeout <= 0:
timeout = 0
# changed
if timeout is None:
timeout = -1
elif timeout < -1:
timeout = 0
what if "timeout=-1" ?
- currently it would result in being timeout=0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current
if timeout is None:
timeout = -1
elif timeout <= 0:
timeout = 0
changed
if timeout is None:
timeout = -1
elif timeout < -1:
timeout = 0
what if "timeout=-1" ?
https://bugs.python.org/issue32842